vvcephei commented on pull request #11236: URL: https://github.com/apache/kafka/pull/11236#issuecomment-902407705
Thanks, @ableegoldman ! I agree it might be overkill, and I wouldn't fault the conservative approach. The reason I went for a blanket approach is that it seems like 30 seconds is an awfully long time to wait for a session timeout in these scenarios, when we expect the full test run to complete within a couple of minutes. It seems like network glitches are pretty common when we run these, so I'm afraid we'll just be playing whack-a-mole by fixing individual tests as they time out due to this setting change. Thanks for the reference to your other PR! I just verified that we are now passing in the decreased session interval to that class via the properties file, so it should no longer be necessary to set it in the java source. I've reverted that commit in this PR, and am re-running the build just to be on the safe side. Once it passes, I'll go ahead and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
