ijuma commented on a change in pull request #11239:
URL: https://github.com/apache/kafka/pull/11239#discussion_r692964096
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -91,6 +91,10 @@ class KafkaServer(
threadNamePrefix: Option[String] = None,
enableForwarding: Boolean = false
) extends KafkaBroker with Server {
+ @volatile private var _brokerState: BrokerState = BrokerState.NOT_RUNNING
Review comment:
Can we move this alongside the other vars and move the `defs` to after
the vars? The reason is that `vars` are both mutable and definition of ordering
matters. It's good to have them all in one place. `defs` definition order does
not matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
