showuon commented on a change in pull request #11247:
URL: https://github.com/apache/kafka/pull/11247#discussion_r693315762



##########
File path: docs/streams/developer-guide/dsl-api.html
##########
@@ -1952,9 +1951,8 @@ <h4 class="anchor-heading"><a 
id="streams_concepts_globalktable" class="anchor-l
                                                 </div></blockquote>
                                         </li>
                                         <li><p class="first">For each input 
record on one side that does not have any match on the other side, the <code 
class="docutils literal"><span class="pre">ValueJoiner</span></code> will be 
called with <code class="docutils literal"><span 
class="pre">ValueJoiner#apply(leftRecord.value,</span> <span 
class="pre">null)</span></code> or
-                                            <code class="docutils 
literal"><span class="pre">ValueJoiner#apply(null,</span> <span 
class="pre">rightRecord.value)</span></code>, respectively; this explains the 
row with timestamp=60, timestamp=80, and timestamp=100 in the table below, 
which lists <code class="docutils literal"><span class="pre">[E,</span> <span 
class="pre">null]</span></code>,
-                                            <code class="docutils 
literal"><span class="pre">[F,</span> <span class="pre">null]</span></code>, 
and <code class="docutils literal"><span class="pre">[null,</span> <span 
class="pre">f]</span></code> in the OUTER JOIN column.
-                                            Note that these left and right 
results are emitted after the specified grace period passed. 
<strong>Caution:</strong> using the deprecated <code class="docutils 
literal"><span class="pre">JoinWindows.of(...).grace(...)</span></code> API 
might result in eagerly emitted spurious left/right results.</p>
+                                            <code class="docutils 
literal"><span class="pre">ValueJoiner#apply(null,</span> <span 
class="pre">rightRecord.value)</span></code>, respectively; this explains the 
row with timestamp=3 in the table below, which lists <code class="docutils 
literal"><span class="pre">[A,</span> <span class="pre">null]</span></code> in 
the OUTER JOIN column
+                                            (unlike LEFT JOIN, <code 
class="docutils literal"><span class="pre">[null,</span> <span 
class="pre">x]</span></code> is possible, too, but no such example is shown in 
the table).</p>

Review comment:
       This is reverted this PR: https://github.com/apache/kafka/pull/11172




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to