TomerWizman commented on a change in pull request #11250:
URL: https://github.com/apache/kafka/pull/11250#discussion_r694530218
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##########
@@ -178,15 +178,15 @@ void openDB(final Map<String, Object> configs, final File
stateDir) {
// Setup statistics before the database is opened, otherwise the
statistics are not updated
// with the measurements from Rocks DB
- maybeSetUpStatistics(configs);
+ setStatisticsIfNeeded(configs);
openRocksDB(dbOptions, columnFamilyOptions);
open = true;
addValueProvidersToMetricsRecorder();
}
- private void maybeSetUpStatistics(final Map<String, Object> configs) {
+ private void setStatisticsIfNeeded(final Map<String, Object> configs) {
Review comment:
I saw that the "IfNeeded" convention is used in a lot of places. I can
revert it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
