dajac commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r694876130
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##########
@@ -158,25 +158,24 @@ private void handleError(
Set<CoordinatorKey> groupsToUnmap,
Set<CoordinatorKey> groupsToRetry
) {
+ final String requestErrorMsg = "OffsetCommit request for group id {}
returned error {}. Will retry.";
Review comment:
I would rather keep it inline to stay consistent with the other cases.
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##########
@@ -158,25 +158,24 @@ private void handleError(
Set<CoordinatorKey> groupsToUnmap,
Set<CoordinatorKey> groupsToRetry
) {
+ final String requestErrorMsg = "OffsetCommit request for group id {}
returned error {}. Will retry.";
switch (error) {
- // If the coordinator is in the middle of loading, then we just
need to retry.
+ // If the coordinator is in the middle of loading, or rebalance is
in progress, then we just need to retry.
case COORDINATOR_LOAD_IN_PROGRESS:
- log.debug("OffsetCommit request for group id {} failed because
the coordinator" +
- " is still in the process of loading state. Will retry.",
groupId.idValue);
+ case REBALANCE_IN_PROGRESS:
+ log.debug(requestErrorMsg, groupId.idValue, error);
groupsToRetry.add(groupId);
break;
// If the coordinator is not available, then we unmap and retry.
case COORDINATOR_NOT_AVAILABLE:
case NOT_COORDINATOR:
- log.debug("OffsetCommit request for group id {} returned error
{}. Will retry.",
- groupId.idValue, error);
+ log.debug(requestErrorMsg, groupId.idValue, error);
Review comment:
Perhaps, we could say `.... Will rediscover the coordinator and retry.`
in this case. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
