ableegoldman commented on pull request #11248:
URL: https://github.com/apache/kafka/pull/11248#issuecomment-905097291


   Fix is available here: https://github.com/apache/kafka/pull/11257
   
   This also got me digging into why we had to make `stop()` public in 3.0, and 
seem to now be required to manually invoke both `start()` and `stop()` in every 
single integration test...which is incredibly error prone (or rather, 
resource-leakage prone). I fixed the 2.8 build in a way that should prevent 
future backports from breaking the 2.8 branch specifically, but I'm going to 
look into just improving how we do this in 3.0+ so we don't need to worry about 
breaking older branches than 2.8, or leaking resources by forgetting to clean 
up this cluster... 😬 
   
   Anyways, thanks very much for bringing this up!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to