[
https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404165#comment-17404165
]
Yanwen Lin commented on KAFKA-10038:
------------------------------------
Hi [~tigertan], I'm working on this issue and trying to understand the
requirement here:
* Seems like for any of the *ConsumerPerformance*, ProducerPerformance,
ConsoleConsumer, ConsoleProducer, they already accept the property *client.id*.
We can add this into a config file and send it via a option like
consumer.config/producer.config (tried and this works). *So do you mean this
task is more for: If no client.id is set, we should give a default one.*
* You also mentioned that we can unify the way ConsoleConsumer and
ConsoleProducer are handling the client.id. What do you mean by handling? Since
only ConsoleProducer will set a default client.id. *By "unify", do you mean we
should give default client.id in ConsoleConsumer?*
* Why providing client.id can help do the quota testing? What is the
connection btw those two?
Hi [~showuon], since this is a simple change (provide default if not set
client.id), *may I ask why do we need a KIP here?*
Thanks!
> ConsumerPerformance.scala supports the setting of client.id
> -----------------------------------------------------------
>
> Key: KAFKA-10038
> URL: https://issues.apache.org/jira/browse/KAFKA-10038
> Project: Kafka
> Issue Type: Improvement
> Components: consumer, core
> Affects Versions: 2.1.1
> Environment: Trunk branch
> Reporter: tigertan
> Assignee: Yanwen Lin
> Priority: Minor
> Labels: newbie, performance
>
> ConsumerPerformance.scala supports the setting of "client.id", which is a
> reasonable requirement, and the way "console consumer" and "console producer"
> handle "client.id" can be unified. "client.id" defaults to
> "perf-consumer-client".
> We often use client.id in quotas, if the script of
> kafka-producer-perf-test.sh supports the setting of "client.id" , we can do
> quota testing through scripts without writing our own consumer programs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
