vamossagar12 commented on a change in pull request #11076:
URL: https://github.com/apache/kafka/pull/11076#discussion_r698177313
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -590,7 +590,14 @@ boolean runLoop() {
log.warn("Detected the states of tasks " + e.corruptedTasks()
+ " are corrupted. " +
"Will close the task as dirty and re-create and
bootstrap from scratch.", e);
try {
+ // check if any active task got corrupted. We will trigger
a rebalance in that case.
+ // once the task corruptions have been handled
+ Set<Task> corruptedActiveTasks =
taskManager.anyActiveTasksCorrupted(e.corruptedTasks());
Review comment:
Yeah that makes sense. I had the same thought but wasn't sure if I
should go ahead and change the return type. I have made the changes. The method
name might need to change though- right now it's unchanged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
