jlprat commented on a change in pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#discussion_r698268258
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -509,7 +526,7 @@ private void handleStreamsUncaughtException(final Throwable
throwable,
break;
case SHUTDOWN_CLIENT:
log.error("Encountered the following exception during
processing " +
- "and the registered exception handler opted to " +
action + "." +
+ "and Kafka Streams opted to " + action + "." +
Review comment:
Changed the error log line as mentioned.
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -495,9 +498,25 @@ private void replaceStreamThread(final Throwable
throwable) {
}
}
+ private StreamsUncaughtExceptionHandler.StreamThreadExceptionResponse
getActionForThrowable(final Throwable throwable,
+
final StreamsUncaughtExceptionHandler streamsUncaughtExceptionHandler)
{
+ final StreamsUncaughtExceptionHandler.StreamThreadExceptionResponse
action;
+ // Exception might we wrapped within a StreamsException one
Review comment:
Updated now, the `if` statement now only checks the wrapped exception if
it exists, and decides upon that. See next line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
