showuon commented on a change in pull request #11292:
URL: https://github.com/apache/kafka/pull/11292#discussion_r704188256
##########
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java
##########
@@ -80,6 +80,15 @@
static final long SEGMENT_INTERVAL = 60_000L;
static final long RETENTION_PERIOD = 2 * SEGMENT_INTERVAL;
+ final long defaultStartTime = SEGMENT_INTERVAL - 4L;
+
+ final KeyValue<Windowed<Integer>, String> zero = windowedPair(0, "zero",
defaultStartTime);
+ final KeyValue<Windowed<Integer>, String> one = windowedPair(1, "one",
defaultStartTime + 1);
+ final KeyValue<Windowed<Integer>, String> two = windowedPair(2, "two",
defaultStartTime + 2);
+ final KeyValue<Windowed<Integer>, String> three = windowedPair(3, "three",
defaultStartTime + 2);
Review comment:
Thanks for your comment, but here, I make it as `defaultStartTime + 2`
on purpose, to test the case that when window starts time is the same, the
forward/backward query API can return the order as expected. I updated the PR
description to make it clear. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
