[ 
https://issues.apache.org/jira/browse/KAFKA-13256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413010#comment-17413010
 ] 

Mickael Maison commented on KAFKA-13256:
----------------------------------------

While this does not affect Apache Kafka itself, ConfigDef is public API and 
used by Connect connectors and third party code like Debezium. In a perfect 
world, you can argue the documentation should always be set but as it was a 
small fix, it made sense to merge it.

> Possible NPE in ConfigDef when rendering (enriched) RST or HTML when 
> documentation is not set/NULL
> --------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-13256
>                 URL: https://issues.apache.org/jira/browse/KAFKA-13256
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 3.0.0, 2.8.0
>            Reporter: René Kerner
>            Assignee: René Kerner
>            Priority: Major
>             Fix For: 3.1.0
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> While working on Debezium I discovered the following issue:
> When Kafka's ConfigDef renders the HTML or RST documentation representation 
> of the config definition, it requires `ConfigKey.documentation` member 
> variable to be a java.lang.String instance that's set to an actual value 
> different than NULL, else NPE happens:
> {code:java}
>  b.append(key.documentation.replaceAll("\n", "<br>"));
> {code}
> {code:java}
>  for (String docLine : key.documentation.split("\n")) {
> {code}
>  
> When `documentation` is not set/NULL I suggest to either set a valid String 
> like "No documentation available" or skip that config key.
>  
> I could provide a PR to fix this soon.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to