showuon commented on a change in pull request #11337:
URL: https://github.com/apache/kafka/pull/11337#discussion_r711431126
##########
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java
##########
@@ -463,12 +469,20 @@ public void shouldFetchAndIterateOverExactBinaryKeys() {
sessionStore.put(new Windowed<>(key2, new SessionWindow(8, 100)), "8");
sessionStore.put(new Windowed<>(key3, new SessionWindow(9, 100)), "9");
- final Set<String> expectedKey1 = new HashSet<>(asList("1", "4", "7"));
- assertThat(valuesToSet(sessionStore.findSessions(key1, 0L,
Long.MAX_VALUE)), equalTo(expectedKey1));
- final Set<String> expectedKey2 = new HashSet<>(asList("2", "5", "8"));
- assertThat(valuesToSet(sessionStore.findSessions(key2, 0L,
Long.MAX_VALUE)), equalTo(expectedKey2));
- final Set<String> expectedKey3 = new HashSet<>(asList("3", "6", "9"));
- assertThat(valuesToSet(sessionStore.findSessions(key3, 0L,
Long.MAX_VALUE)), equalTo(expectedKey3));
+ final List<String> expectedKey1 = asList("1", "4", "7");
+ try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.findSessions(key1, 0L, Long.MAX_VALUE)) {
+ assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey1)));
+ }
Review comment:
We forgot to close the `KeyValueIterator` instance returned by the
`findSessions`. Fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
