C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r718556405



##########
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java
##########
@@ -499,13 +516,15 @@ ConfigDef getConfigDefFromConfigProvidingClass(String 
key, Class<?> cls) {
                         aliasKind + " is abstract and cannot be created. Did 
you mean " + childClassNames + "?";
                 throw new ConfigException(key, String.valueOf(cls), message);
             }
-            T transformation;
+            T plugin;
             try {
-                transformation = Utils.newInstance(cls, baseClass);
+                plugin = Utils.newInstance(cls, baseClass);
             } catch (Exception e) {
-                throw new ConfigException(key, String.valueOf(cls), "Error 
getting config definition from " + baseClass.getSimpleName() + ": " + 
e.getMessage());
+                // Log the entire exception here in order to provide a stack 
trace that can be useful for debugging classloading issues
+                log.error("Failed to instantiate {} '{}'", 
baseClass.getSimpleName(), cls, e);

Review comment:
       Added this error message based on discussion of a similar error-handling 
situation 
[here](https://github.com/apache/kafka/pull/11349#discussion_r715452885).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to