guozhangwang commented on a change in pull request #11367: URL: https://github.com/apache/kafka/pull/11367#discussion_r718112421
########## File path: gradle.properties ########## @@ -20,7 +20,7 @@ group=org.apache.kafka # - tests/kafkatest/__init__.py # - tests/kafkatest/version.py (variable DEV_VERSION) # - kafka-merge-pr.py -version=3.1.0-SNAPSHOT +version=3.1.0-SNAPSHOT-SSJOIN Review comment: This is for benchmarking, will remove later. ########## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/ListValueStoreTest.java ########## @@ -177,27 +180,47 @@ public void shouldGetAllReturnTimestampOrderedRecords() { } @Test - public void shouldAllowDeleteWhileIterateRecords() { - listStore.put(0, "zero1"); - listStore.put(0, "zero2"); - listStore.put(1, "one"); + public void shouldAllowDeleteWhileIterateRecords2() { Review comment: Adding more randomness into this test to check if deleting after iterating could still have defined behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org