gharris1727 commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720414123
##########
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java
##########
@@ -45,7 +45,7 @@
private static final Logger log =
LoggerFactory.getLogger(EmbeddedConnectClusterAssertions.class);
public static final long WORKER_SETUP_DURATION_MS =
TimeUnit.SECONDS.toMillis(60);
- public static final long VALIDATION_DURATION_MS =
TimeUnit.SECONDS.toMillis(30);
+ public static final long VALIDATION_DURATION_MS =
TimeUnit.SECONDS.toMillis(5);
Review comment:
> lowered the value because I used test-driven development for this PR
and at the beginning some of my failing test cases were talking 30 seconds each.
Ah, this is a productivity win for everyone using the embedded assertions
then. :+1:
> we could revamp the validation assertions to not use
TestUtils::waitForCondition at all and only issue one validation request.
I don't think this is necessary, and any tests that rely on retries for
validations would definitely flake out in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
