mimaison commented on a change in pull request #11394:
URL: https://github.com/apache/kafka/pull/11394#discussion_r729805385
##########
File path: release.py
##########
@@ -178,6 +178,16 @@ def sftp_mkdir(dir):
# This is ok. The command fails if the directory already exists
pass
+def sftp_upload(dir):
+ try:
+ cmd_str = """
+cd public_html
+put -r %s
+""" % dir
+ cmd("Uploading '%s' under public_html in your Apache home directory" %
dir, "sftp -b - %s...@home.apache.org" % apache_id, stdin=cmd_str,
allow_failure=True, num_retries=3)
Review comment:
Yes like it used to work with rsync
##########
File path: release.py
##########
@@ -621,7 +631,8 @@ def select_gpg_key():
cmd("Listing artifacts to be uploaded:", "ls -R %s" % artifacts_dir)
cmd("Zipping artifacts", "tar -czf %s.tar.gz %s" % (artifact_name,
artifact_name), cwd=work_dir)
-if not user_ok("Have you uploaded artifacts in %s, listed above, to
public_html in your Apache home directory (y/n)?: " % artifacts_dir):
+sftp_upload(artifacts_dir)
Review comment:
Yes that's what I understood. I've made the changes, testing it now ...
##########
File path: release.py
##########
@@ -621,7 +631,8 @@ def select_gpg_key():
cmd("Listing artifacts to be uploaded:", "ls -R %s" % artifacts_dir)
cmd("Zipping artifacts", "tar -czf %s.tar.gz %s" % (artifact_name,
artifact_name), cwd=work_dir)
-if not user_ok("Have you uploaded artifacts in %s, listed above, to
public_html in your Apache home directory (y/n)?: " % artifacts_dir):
+sftp_upload(artifacts_dir)
Review comment:
Thanks for the suggestion, I pushed an update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
