ableegoldman commented on a change in pull request #11381:
URL: https://github.com/apache/kafka/pull/11381#discussion_r730071032
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -513,8 +514,8 @@ private boolean wrappedExceptionIsIn(final Throwable
throwable, final Set<Class<
return action;
}
- private void handleStreamsUncaughtException(final Throwable throwable,
- final
StreamsUncaughtExceptionHandler streamsUncaughtExceptionHandler) {
+ protected void handleStreamsUncaughtException(final Throwable throwable,
Review comment:
Ah, I had meant to pass in `namedTopologyException.getCause` to the
handler. Yes, you should not need to unwrap twice, that was just a mistake in
the PR. I'm on board with wrapping everything as a StreamsException though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
