vvcephei commented on a change in pull request #11406: URL: https://github.com/apache/kafka/pull/11406#discussion_r731305800
########## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import java.util.Map; +import java.util.Map.Entry; +import org.apache.kafka.common.utils.Bytes; +import org.apache.kafka.streams.query.Query; +import org.apache.kafka.streams.query.Query.QueryResult; +import org.apache.kafka.streams.query.RawKeyQuery; +import org.apache.kafka.streams.query.RawScanQuery; +import org.apache.kafka.streams.state.KeyValueIterator; +import org.apache.kafka.streams.state.KeyValueStore; + +public final class StoreQueryUtils { + + // make this class uninstantiable + private StoreQueryUtils() { + } + + public static <R> QueryResult<R> requireKVQuery( + final Query<R> query, + final KeyValueStore<Bytes, byte[]> kvStore) { + final QueryResult<R> r = StoreQueryUtils.handleKVQuery(query, kvStore); + r.throwIfFailure(); + return r; + } + + public static <R> QueryResult<R> handleKVQuery( + final Query<R> query, + final KeyValueStore<Bytes, byte[]> kvStore) { + + final long start = System.nanoTime(); + if (query instanceof RawKeyQuery) { Review comment: Can you elaborate, maybe with an example of what you mean? I'm not a big fan of these instance checks, and I wish that we had class switch statements to make this more efficient (but they don't exist until Java 17). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
