mimaison commented on a change in pull request #11419:
URL: https://github.com/apache/kafka/pull/11419#discussion_r732757865
##########
File path:
clients/src/main/java/org/apache/kafka/common/metrics/MetricsContext.java
##########
@@ -24,16 +24,23 @@
* MetricsContext encapsulates additional contextLabels about metrics exposed
via a
* {@link org.apache.kafka.common.metrics.MetricsReporter}
*
- * The contextLabels map provides following information:
- * - a <code>_namespace</node> field indicating the component exposing metrics
- * e.g. kafka.server, kafka.consumer
- * {@link JmxReporter} uses this as prefix for mbean names
+ * <p>The {@link #contextLabels()} map provides following information:
+ * <dl>
+ * <dt>in all components</dt>
+ * <dd>a <code>_namespace</node> field indicating the component exposing
metrics
+ * e.g. kafka.server, kafka.consumer.
+ * The {@link JmxReporter} uses this as prefix for MBean names</ul>
Review comment:
Do we need `</ul>`?
##########
File path:
clients/src/main/java/org/apache/kafka/common/metrics/MetricsContext.java
##########
@@ -24,16 +24,23 @@
* MetricsContext encapsulates additional contextLabels about metrics exposed
via a
* {@link org.apache.kafka.common.metrics.MetricsReporter}
*
- * The contextLabels map provides following information:
- * - a <code>_namespace</node> field indicating the component exposing metrics
- * e.g. kafka.server, kafka.consumer
- * {@link JmxReporter} uses this as prefix for mbean names
+ * <p>The {@link #contextLabels()} map provides following information:
+ * <dl>
+ * <dt>in all components</dt>
+ * <dd>a <code>_namespace</node> field indicating the component exposing
metrics
Review comment:
`</node>` -> `</code>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
