ableegoldman commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r733239524
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -636,6 +636,10 @@ boolean runLoop() {
failedStreamThreadSensor.record();
this.streamsUncaughtExceptionHandler.accept(e);
return false;
+ } catch (final StreamsException e) {
Review comment:
Ah, good catch (tbh I kind of feel we shouldn't pass it to the handler
at all and just shut down the application, but that's a discussion for another
time/place)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
