ableegoldman commented on pull request #11439: URL: https://github.com/apache/kafka/pull/11439#issuecomment-954215056
@showuon something like this would be a good fix for 3.1, especially since it's quick and code freeze is coming up. I also feel it is low-risk, for one thing this validation clearly can't be trusted at the moment anyways, for another I think it's fair to trust the CooperativeStickyAssignor since we have many tests for it -- we could just move the validation check from the ConsumerCoordinator into the CooperativeStickyAssignor itself, but we essentially already do exactly that inside the `adjustAssignment` method. So I support merging this (once it's cleaned up) for 3.1 and then doing something like adding the generation to the ConsumerProtocol as you suggested for the long term fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
