vamossagar12 commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r739172245



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -601,6 +608,10 @@ boolean runLoop() {
                 if (size != -1L) {
                     cacheResizer.accept(size);
                 }
+                final long bufferBytesSize = 
maxBufferResizeSize.getAndSet(-1L);

Review comment:
       > Thanks for the PR! Lmk if you have any questions about any of my 
comments/questions -- I think the main thing is just that we, unfortunately, 
can't get rid of any of the code handling the old configs just yet, since not 
everyone will upgrade their code off of deprecated APIs right away (though we 
wish they would!)
   
   Thanks for the review. I have added some comments/questions. Other 
suggestions, make total sense and would incorporate them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to