[GitHub] [kafka] dongjinleekr opened a new pull request #11474: KAFKA-13354: Topic metrics count request rate inconsistently with other request metrics

[GitBox]

dongjinleekr opened a new pull request #11474:
URL: https://github.com/apache/kafka/pull/11474


   I inspected this issue a little bit and found the following:
   
   1. There are 18 metrics in `kafka.server:type=BrokerTopicMetrics` and 4 of 
them should be counted per request, but actually counted per `TopicPartition`:
   
       - `kafka.server:type=BrokerTopicMetrics,name=TotalProduceRequestsPerSec`
       - `kafka.server:type=BrokerTopicMetrics,name=TotalFetchRequestsPerSec`
       - `kafka.server:type=BrokerTopicMetrics,name=FailedProduceRequestsPerSec`
       - `kafka.server:type=BrokerTopicMetrics,name=FailedFetchRequestsPerSec`
   
   2. 5 of them are omitted in the documentation (see: #11473)
   
       - `kafka.server:type=BrokerTopicMetrics,name=TotalProduceRequestsPerSec`
       - `kafka.server:type=BrokerTopicMetrics,name=TotalFetchRequestsPerSec`
       - `kafka.server:type=BrokerTopicMetrics,name=FailedProduceRequestsPerSec`
       - `kafka.server:type=BrokerTopicMetrics,name=FailedFetchRequestsPerSec`
       - `kafka.server:type=BrokerTopicMetrics,name=BytesRejectedPerSec`
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org