jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r744905470
##########
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##########
@@ -301,7 +299,9 @@ public FetchRequestData build() {
if (nextData != null) {
// We basically check if the new partition had the same
topic ID. If not,
// we add it to the "replaced" set.
- if (!prevData.topicId.equals(nextData.topicId) &&
!prevData.topicId.equals(Uuid.ZERO_UUID)) {
+ if (!prevData.topicId.equals(nextData.topicId)
+ && !prevData.topicId.equals(Uuid.ZERO_UUID)
+ && !nextData.topicId.equals(Uuid.ZERO_UUID)) {
Review comment:
I realize we may still want this as if the partition data is exactly the
same, we will actually ignore the downgrade which is not good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
