hachikuji commented on a change in pull request #11449: URL: https://github.com/apache/kafka/pull/11449#discussion_r745072515
########## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ########## @@ -319,23 +319,29 @@ public void disconnect(String nodeId) { if (connectionStates.isDisconnected(nodeId)) return; + log.info("Client requested disconnect from node {} (invoking callbacks for in-flight requests)", nodeId); Review comment: I found it a little simpler to add a separate log message for the coordinator case. Let me know if that seems reasonable. In general, I'm not too worried about the verbosity of this message since client-initiated disconnects should be relatively rare (e.g. after session or request timeouts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org