hachikuji commented on a change in pull request #11448:
URL: https://github.com/apache/kafka/pull/11448#discussion_r745839478
##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -204,16 +204,19 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
private val reconfigurables = mutable.Buffer[Reconfigurable]()
private val brokerReconfigurables = mutable.Buffer[BrokerReconfigurable]()
private val lock = new ReentrantReadWriteLock
- private var currentConfig = kafkaConfig
+ private var currentConfig: KafkaConfig = null
private val dynamicConfigPasswordEncoder =
maybeCreatePasswordEncoder(kafkaConfig.passwordEncoderSecret)
- private[server] def initialize(zkClient: KafkaZkClient): Unit = {
+ private[server] def initialize(zkClientOpt: Option[KafkaZkClient]): Unit = {
Review comment:
It looks like dynamic configs get initialized later when we load the
metadata log. I think this probably could be improved. Do you see any specific
issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
