dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r746404173
##########
File path: core/src/test/scala/unit/kafka/server/FetchSessionTest.scala
##########
@@ -967,6 +967,113 @@ class FetchSessionTest {
.setErrorCode(errorCode)
}
+ @Test
Review comment:
I wrote that test to illustrate how we could improve the readability. My
concern is that they are so many lines/assertions in
`testUpdatedPartitionResolvesId` and `testToForgetCases` that we get distracted
and we have almost missed the most important assertions - the ones which
validate what the session contains (`assertPartitionsOrder`).
`assertPartitionsOrder` is actually the piece which ensures that the names are
resolved or not, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
