cadonna commented on a change in pull request #11499:
URL: https://github.com/apache/kafka/pull/11499#discussion_r749476568
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java
##########
@@ -0,0 +1,50 @@
+package org.apache.kafka.streams.processor.internals;
+
+import java.time.Duration;
+import java.util.List;
+
+public interface StateUpdater {
+
+ /**
+ * Adds a task (active or standby) to the state updater.
+ *
+ * The state of the task will be updated.
+ *
+ * @param task task
+ */
+ void add(final Task task);
+
+ /**
+ * Removes a task (active and standby) from the state updater.
+ *
+ * A task is removed from the state updater irrespective of whether its
state is up-to-date or not.
+ *
+ * @param task tasks to remove
+ */
+ void remove(final Task task);
Review comment:
Each time a task is suspended in state `RESTORING`, we need to remove it
from the state updater.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java
##########
@@ -0,0 +1,50 @@
+package org.apache.kafka.streams.processor.internals;
+
+import java.time.Duration;
+import java.util.List;
+
+public interface StateUpdater {
+
+ /**
+ * Adds a task (active or standby) to the state updater.
+ *
+ * The state of the task will be updated.
+ *
+ * @param task task
+ */
+ void add(final Task task);
Review comment:
Each time an active or standby task transits to state `RESTORING` it
needs to be added to the state updater.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
