guozhangwang commented on a change in pull request #11496:
URL: https://github.com/apache/kafka/pull/11496#discussion_r752509125
##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -291,23 +291,23 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
dynamicDefaultConfigs.clone()
}
- private[server] def updateBrokerConfig(brokerId: Int, persistentProps:
Properties): Unit = CoreUtils.inWriteLock(lock) {
+ private[server] def updateBrokerConfig(brokerId: Int, persistentProps:
Properties, doLog: Boolean = false): Unit = CoreUtils.inWriteLock(lock) {
Review comment:
I think in order to not modify the behavior in `ConfigHandler`, we need
to make the default `doLog` as true, and then explicitly set it in line 215
above as `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
