hachikuji commented on a change in pull request #11452:
URL: https://github.com/apache/kafka/pull/11452#discussion_r755351132
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##########
@@ -1183,20 +1183,42 @@ private TxnOffsetCommitHandler
txnOffsetCommitHandler(TransactionalRequestResult
return new TxnOffsetCommitHandler(result, builder);
}
+ private void throwPendingTransitionError(String operation) {
+ throw new KafkaException("Cannot attempt operation `" + operation + "`
"
Review comment:
I also slightly favor `IllegalStateException`, but I used
`KafkaException` for consistency with `transitionTo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
