cadonna commented on a change in pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#discussion_r755399596
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java
##########
@@ -337,7 +341,18 @@ public void shouldGetToRunningWithOnlyGlobalTopology()
throws Exception {
startStreams();
waitForApplicationState(singletonList(kafkaStreams), State.RUNNING,
Duration.ofSeconds(30));
- kafkaStreams.close();
Review comment:
I somehow agree. But it also seems like we are missing tests for the
error case where the state of the Streams client closes to `ERROR`. I am fine
with removing the change of the test from this PR and just make a one-time
manual verification of the existence and absence of the log message. However,
then we need a separate PR for the missing test or a ticket that documents that
a test is missing.
Have you had a look into `GlobalStreamThreadTest`? Could we add something
there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
