cmccabe commented on a change in pull request #11416:
URL: https://github.com/apache/kafka/pull/11416#discussion_r761580433



##########
File path: 
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java
##########
@@ -122,19 +126,13 @@ private void 
incrementalAlterConfigResource(ConfigResource configResource,
                     newValue = opValue;
                     break;
                 case DELETE:
-                    if (opValue != null) {

Review comment:
       There are existing integration tests that pass a non-null value. This PR 
doesn't convert those tests over but a future one will.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to