vvcephei commented on a change in pull request #11557: URL: https://github.com/apache/kafka/pull/11557#discussion_r762147628
########## File path: streams/src/main/java/org/apache/kafka/streams/query/Position.java ########## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.query; + + +import org.apache.kafka.common.annotation.InterfaceStability.Evolving; + +import java.util.Collections; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Objects; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; + +/** + * A representation of a position vector with respect to a set of topic partitions. For example, in + * Interactive Query ({@link org.apache.kafka.streams.KafkaStreams#query(StateQueryRequest)}, a + * query result may contain information from multiple store partitions, each of which contains + * information from multiple input topics' partitions. This class can be used to summarize all of + * that positional information. + * <p> + * This class is threadsafe, although it is mutable. Readers are recommended to use {@link + * Position#copy()} to avoid seeing mutations to the Position after they get the reference. For + * examples, when a store executes a {@link org.apache.kafka.streams.processor.StateStore#query(Query, + * PositionBound, boolean)} request and returns its current position via {@link + * QueryResult#setPosition(Position)}, it should pass a copy of its position instead of the mutable + * reference. + */ +@Evolving +public class Position { Review comment: Oops! I'm sorry about this and the other gaps you pointed out. I did make a couple of passes to compare with the KIP, but I obviously missed some things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
