mimaison commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r765876199
##########
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##########
@@ -206,11 +210,25 @@ object ConsoleProducer {
.describedAs("size")
.ofType(classOf[java.lang.Integer])
.defaultsTo(1024*100)
- val propertyOpt = parser.accepts("property", "A mechanism to pass
user-defined properties in the form key=value to the message reader. " +
- "This allows custom configuration for a user-defined message reader.
Default properties include:\n" +
- "\tparse.key=true|false\n" +
- "\tkey.separator=<key.separator>\n" +
- "\tignore.error=true|false")
+ val propertyOpt = parser.accepts("property",
+ """A mechanism to pass user-defined properties in the form key=value to
the message reader. This allows custom configuration for a user-defined message
reader.
+ |Default properties include:
+ | parse.key=false
+ | parse.headers=false
+ | ignore.error=false
+ | key.separator=\t
+ | headers.delimiter=\t
+ | headers.separator=,
+ | headers.key.separator=:
+ |Default parsing pattern when:
+ | parse.headers=true & parse.key=true:
Review comment:
Maybe it's time to use more than 80 columns! But that's a discussion for
another KIP.
As all these `parse.*` default to `false`, what about only listing the
configs set to `true` in the example?
For example:
`parse.headers=false & parse.key=true` -> `parse.key=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
