jeffkbkim commented on a change in pull request #11566:
URL: https://github.com/apache/kafka/pull/11566#discussion_r770278248
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -181,6 +182,8 @@ class GroupCoordinator(val brokerId: Int,
responseCallback(JoinGroupResult(memberId, Errors.UNKNOWN_MEMBER_ID))
case Some(group) =>
group.inLock {
+ if (reason != null)
+ info(s"memberId=$memberId with groupInstanceId=$groupInstanceId
is attempting to join groupId=$groupId due to: $reason")
Review comment:
yeah, that was my original thoughts as well. i believe you are referring
to `maybePrepareRebalance(group: GroupMetadata, reason: String)`.
methods that are referencing this are:
- `addMemberAndRebalance`
- `doSyncGroup` (NA)
- `removeMemberAndUpdateGroup` (NA)
- `updateMemberAndRebalance`
- `updateStaticMemberAndRebalance`
i've passed the reason into all parent methods. also, i've updated
`updateStaticMemberAndRebalance`'s direct call to `prepareRebalance()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
