YeonCheolGit commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r780354832
########## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.metadata.authorizer; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.acl.AclBinding; +import org.apache.kafka.common.acl.AclBindingFilter; +import org.apache.kafka.common.errors.ApiException; +import org.apache.kafka.common.errors.UnknownServerException; +import org.apache.kafka.common.requests.ApiError; +import org.apache.kafka.server.authorizer.AclCreateResult; +import org.apache.kafka.server.authorizer.AclDeleteResult; +import org.apache.kafka.server.authorizer.AuthorizableRequestContext; +import org.apache.kafka.server.authorizer.Authorizer; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionStage; + + +/** + * An interface for Authorizers which store state in the __cluster_metadata log. + * + * These methods must all be thread-safe. + */ +public interface ClusterMetadataAuthorizer extends Authorizer { + /** + * Set the mutator object which should be used for creating and deleting ACLs. + */ + void setAclMutator(AclMutator aclMutator); + + /** + * Get the mutator object which should be used for creating and deleting ACLs. + * + * @throws org.apache.kafka.common.errors.NotControllerException + * If the aclMutator was not set. + */ + AclMutator aclMutatorOrException(); + + /** + * Load the ACLs in the given map. Anything not in the map will be removed. + * The authorizer will also wait for this initial snapshot load to complete when + * coming up. + */ + void loadSnapshot(Map<Uuid, StandardAcl> acls); + + /** + * Add a new ACL. Any ACL with the same ID will be replaced. + */ + void addAcl(StandardAcl acl); + + /** + * Remove the ACL with the given ID. + */ + void removeAcl(Uuid id); + + /** + * Returns true if this authorizer contains an ACL equivalent to the specified one. + */ + boolean hasEquivalentAcl(StandardAcl acl); + + default List<? extends CompletionStage<AclCreateResult>> createAcls( + AuthorizableRequestContext requestContext, + List<AclBinding> aclBindings) { + List<CompletableFuture<AclCreateResult>> futures = new ArrayList<>(aclBindings.size()); + AclMutator aclMutator = aclMutatorOrException(); + aclBindings.forEach(b -> futures.add(new CompletableFuture<>())); + aclMutator.createAcls(aclBindings).whenComplete((results, throwable) -> { + if (throwable == null && results.size() != futures.size()) { Review comment: if it has to check `futures`'s `size` every time, what about assign one time and use many times? ```suggestion final int futuresSize = futures.size(); if (throwable == null && results.size() != futuresSize) { ``` ########## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.metadata.authorizer; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.acl.AclBinding; +import org.apache.kafka.common.acl.AclBindingFilter; +import org.apache.kafka.common.errors.ApiException; +import org.apache.kafka.common.errors.UnknownServerException; +import org.apache.kafka.common.requests.ApiError; +import org.apache.kafka.server.authorizer.AclCreateResult; +import org.apache.kafka.server.authorizer.AclDeleteResult; +import org.apache.kafka.server.authorizer.AuthorizableRequestContext; +import org.apache.kafka.server.authorizer.Authorizer; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionStage; + + +/** + * An interface for Authorizers which store state in the __cluster_metadata log. + * + * These methods must all be thread-safe. + */ +public interface ClusterMetadataAuthorizer extends Authorizer { + /** + * Set the mutator object which should be used for creating and deleting ACLs. + */ + void setAclMutator(AclMutator aclMutator); + + /** + * Get the mutator object which should be used for creating and deleting ACLs. + * + * @throws org.apache.kafka.common.errors.NotControllerException + * If the aclMutator was not set. + */ + AclMutator aclMutatorOrException(); + + /** + * Load the ACLs in the given map. Anything not in the map will be removed. + * The authorizer will also wait for this initial snapshot load to complete when + * coming up. + */ + void loadSnapshot(Map<Uuid, StandardAcl> acls); + + /** + * Add a new ACL. Any ACL with the same ID will be replaced. + */ + void addAcl(StandardAcl acl); + + /** + * Remove the ACL with the given ID. + */ + void removeAcl(Uuid id); + + /** + * Returns true if this authorizer contains an ACL equivalent to the specified one. + */ + boolean hasEquivalentAcl(StandardAcl acl); + + default List<? extends CompletionStage<AclCreateResult>> createAcls( + AuthorizableRequestContext requestContext, + List<AclBinding> aclBindings) { + List<CompletableFuture<AclCreateResult>> futures = new ArrayList<>(aclBindings.size()); + AclMutator aclMutator = aclMutatorOrException(); + aclBindings.forEach(b -> futures.add(new CompletableFuture<>())); + aclMutator.createAcls(aclBindings).whenComplete((results, throwable) -> { + if (throwable == null && results.size() != futures.size()) { Review comment: Maybe this is not good suggestion. If it has to check `futures`'s `size` every time, what about assign one time and use many times? Because JVM has to calculate size everytime when it is called. ```suggestion final int futuresSize = futures.size(); if (throwable == null && results.size() != futuresSize) { ``` ########## File path: metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java ########## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.controller; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.acl.AclBinding; +import org.apache.kafka.common.acl.AclBindingFilter; +import org.apache.kafka.common.errors.ApiException; +import org.apache.kafka.common.errors.InvalidRequestException; +import org.apache.kafka.common.errors.UnknownServerException; +import org.apache.kafka.common.metadata.AccessControlEntryRecord; +import org.apache.kafka.common.metadata.RemoveAccessControlEntryRecord; +import org.apache.kafka.common.requests.ApiError; +import org.apache.kafka.metadata.authorizer.ClusterMetadataAuthorizer; +import org.apache.kafka.metadata.authorizer.StandardAcl; +import org.apache.kafka.metadata.authorizer.StandardAclRecordIterator; +import org.apache.kafka.server.authorizer.AclCreateResult; +import org.apache.kafka.server.authorizer.AclDeleteResult; +import org.apache.kafka.server.authorizer.AclDeleteResult.AclBindingDeleteResult; +import org.apache.kafka.server.common.ApiMessageAndVersion; +import org.apache.kafka.timeline.SnapshotRegistry; +import org.apache.kafka.timeline.TimelineHashMap; + +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import java.util.Optional; + + +/** + * The AclControlManager manages any ACLs that are stored in the __cluster_metadata topic. + * If the ACLs are stored externally (such as in ZooKeeper) then there will be nothing for + * this manager to do, and the authorizer field will always be Optional.empty. + * + * Because the Authorizer is being concurrently used by other threads, we need to be + * careful about snapshots. We don't want the Authorizer to act based on partial state + * during the loading process. Therefore, unlike most of the other managers, + * AclControlManager needs to receive callbacks when we start loading a snapshot and when + * we finish. The prepareForSnapshotLoad callback clears the authorizer field, preventing + * any changes from affecting the authorizer until completeSnapshotLoad is called. + * Note that the Authorizer's start() method will block until the first snapshot load has + * completed, which is another reason the prepare / complete callbacks are needed. + */ +public class AclControlManager { + private Optional<ClusterMetadataAuthorizer> authorizer; + private final TimelineHashMap<Uuid, StandardAcl> acls; + + AclControlManager(SnapshotRegistry snapshotRegistry) { + this.authorizer = Optional.empty(); + this.acls = new TimelineHashMap<>(snapshotRegistry, 0); + } + + ControllerResult<List<AclCreateResult>> createAcls(List<AclBinding> acls) { + if (!authorizer.isPresent()) throw new IllegalStateException(); + List<AclCreateResult> results = new ArrayList<>(acls.size()); + List<ApiMessageAndVersion> records = new ArrayList<>(acls.size()); Review comment: same here. If it has to check `futures`'s `size` every time, what about assign one time and use many times? Because JVM has to calculate size everytime when it is called. ```suggestion final int aclsSize = acls.size() List<ApiMessageAndVersion> records = new ArrayList<>(aclsSize); ``` ########## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.metadata.authorizer; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.acl.AclBinding; +import org.apache.kafka.common.acl.AclBindingFilter; +import org.apache.kafka.common.errors.ApiException; +import org.apache.kafka.common.errors.UnknownServerException; +import org.apache.kafka.common.requests.ApiError; +import org.apache.kafka.server.authorizer.AclCreateResult; +import org.apache.kafka.server.authorizer.AclDeleteResult; +import org.apache.kafka.server.authorizer.AuthorizableRequestContext; +import org.apache.kafka.server.authorizer.Authorizer; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionStage; + + +/** + * An interface for Authorizers which store state in the __cluster_metadata log. + * + * These methods must all be thread-safe. + */ +public interface ClusterMetadataAuthorizer extends Authorizer { + /** + * Set the mutator object which should be used for creating and deleting ACLs. + */ + void setAclMutator(AclMutator aclMutator); + + /** + * Get the mutator object which should be used for creating and deleting ACLs. + * + * @throws org.apache.kafka.common.errors.NotControllerException + * If the aclMutator was not set. + */ + AclMutator aclMutatorOrException(); + + /** + * Load the ACLs in the given map. Anything not in the map will be removed. + * The authorizer will also wait for this initial snapshot load to complete when + * coming up. + */ + void loadSnapshot(Map<Uuid, StandardAcl> acls); + + /** + * Add a new ACL. Any ACL with the same ID will be replaced. + */ + void addAcl(StandardAcl acl); + + /** + * Remove the ACL with the given ID. + */ + void removeAcl(Uuid id); + + /** + * Returns true if this authorizer contains an ACL equivalent to the specified one. + */ + boolean hasEquivalentAcl(StandardAcl acl); + + default List<? extends CompletionStage<AclCreateResult>> createAcls( + AuthorizableRequestContext requestContext, + List<AclBinding> aclBindings) { + List<CompletableFuture<AclCreateResult>> futures = new ArrayList<>(aclBindings.size()); + AclMutator aclMutator = aclMutatorOrException(); + aclBindings.forEach(b -> futures.add(new CompletableFuture<>())); + aclMutator.createAcls(aclBindings).whenComplete((results, throwable) -> { + if (throwable == null && results.size() != futures.size()) { Review comment: (My suggestion might not be good) If it has to check `futures`'s `size` every time, what about assign one time and use many times? Because JVM has to calculate size everytime when it is called. ```suggestion final int futuresSize = futures.size(); if (throwable == null && results.size() != futuresSize) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
