vamossagar12 commented on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-1018703979
> > hey @guozhangwang , did you get a chance to look at my above comment? > > Ah yes, for StreamsConfigs in order for backward compatibility we still need to reference some deprecated configs. So: > > 1. For all references of `CACHE_MAX_BYTES_BUFFERING_CONFIG`, we should be replacing it with the new config. We just add the `@suppressWarning` in the place we reference it only for [compatibility](https://github.com/apache/kafka/pull/11424/files#diff-07a8a87d3ee84c3e96918aa131033780cf4bc4d4a12ae376e91c059a9e02d229R1421). > 2. For `BUFFERED_RECORDS_PER_PARTITION_CONFIG`, similarly we use `@suppressWarning` on the code where we need to still reference it for backward compatibility like [here] (https://github.com/apache/kafka/pull/11424/files#diff-0e5e608831150c058e2ad1b45d38ad941739562588ec0fdb97cc9f742919fb1fR119) in TopologyConfig > > Does that sound good to you? If yes we can go ahead and make it done. Thanks @guozhangwang . I added that annotation wherever applicable. Now the only thing pending is the renaming of the total-bytes metric :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
