[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

[GitBox]

showuon commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r799127097



##########
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##########
@@ -168,7 +168,7 @@ object ConsoleProducer {
       .withRequiredArg
       .describedAs("request required acks")
       .ofType(classOf[java.lang.String])
-      .defaultsTo("1")
+      .defaultsTo("-1")

Review comment:
       Good suggestion! Sent a note in the KIP vote thread. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org