[
https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492734#comment-17492734
]
Rob Leland edited comment on KAFKA-13666 at 2/15/22, 9:53 PM:
--------------------------------------------------------------
The only windows 10 machine I have access to is pretty old. When I tried to
build kafka the clients module which is before the steams modules had 10 test
failures, so the build never made it to streams. I also tried :
* Downgrading Scala version
* Disabling parallel gradle builds
* Stopping virus checkers and the like
but no love.
Since my Dev box is Linux building against windows isn't something I am going
to devote a lot of time on.
Again , this patches purpose is to make sure that supported OS test of steams
exceptions are not ignored, which isn't happening now.
*Streams Test drivers cleanup exceptions are ignored*
!kafka test changes.png|width=666,height=280!
Might I suggest that the current definition of best effort support for windows
which does not run tests for windows just isn't realistic and any notion of
supporting windows should be dropped ? Or at least organize the gradle build to
run CI for the parts that might be supported?
I once joined a project whose code base size was comparable to Kafka's ~ 1.4 M
who had not run their tests for 7 years. It was a bear to fix any of their
Integration tests since so many of the interfaces and business rules changed.
We essentially had to start over. When I left they had only about 10% 100K
lines of code under test , but at least we had created test frameworks for all
layers of the code base. We also deleted unused code that had accumulated which
removed almost 400K and was essential to the health of the code base.
was (Author: rleland):
The only windows 10 machine I have access to is pretty old. When I tried to
build kafka the clients module which is before the steams modules had 10 test
failures, so the build never made it to streams. I had tried to stop virus
checkers and the like but no love. Since my Dev box is Linux building against
windows isn't something I am going to devote a lot of time on.
Again , this patches purpose is to make sure that supported OS test of steams
exceptions are not ignored, which isn't happening now.
*Streams Test drivers cleanup exceptions are ignored*
!kafka test changes.png|width=666,height=280!
Might I suggest that the current definition of best effort support for windows
which does not run tests for windows just isn't realistic and any notion of
supporting windows should be dropped ? Or at least organize the gradle build to
run CI for the parts that might be supported?
I once joined a project whose code base size was comparable to Kafka's ~ 1.4 M
who had not run their tests for 7 years. It was a bear to fix any of their
Integration tests since so many of the interfaces and business rules changed.
We essentially had to start over. When I left they had only about 10% 100K
lines of code under test , but at least we had created test frameworks for all
layers of the code base. We also deleted unused code that had accumulated which
removed almost 400K and was essential to the health of the code base.
> Tests should not ignore exceptions for supported OS
> ---------------------------------------------------
>
> Key: KAFKA-13666
> URL: https://issues.apache.org/jira/browse/KAFKA-13666
> Project: Kafka
> Issue Type: Test
> Components: streams
> Affects Versions: 3.0.0
> Reporter: Rob Leland
> Priority: Minor
> Attachments: kafka test changes.png
>
>
> A few of the tests are swallowing exceptions for all operations systems
> because they might fail on windows. This could mask regressions in supported
> OS. When using the testDrivers change this so exceptions are only ignored for
> Windows OS.
> Please see: https://github.com/apache/kafka/pull/11752
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
