junrao commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r813156759
########## File path: clients/src/main/java/org/apache/kafka/common/utils/ChildFirstClassLoader.java ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.utils; + +import org.apache.kafka.common.KafkaException; + +import java.io.File; +import java.io.IOException; +import java.net.URL; +import java.net.URLClassLoader; +import java.util.ArrayList; +import java.util.Enumeration; +import java.util.Locale; +import java.util.NoSuchElementException; + +/** + * A class loader that looks for classes and resources in a specified class path first, before delegating to its parent + * class loader. + */ +public class ChildFirstClassLoader extends URLClassLoader { Review comment: Yes, I understand the intent. However, there are quite a few pluggable components on the broker side right now. Sorting out the classpath dependencies among all of them seems quite complicated. Another way to solve the issue is through shading. A potential conflicting library could be renamed to a different package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
