ableegoldman commented on a change in pull request #11813:
URL: https://github.com/apache/kafka/pull/11813#discussion_r815270807
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##########
@@ -100,7 +100,7 @@ public void start(final NamedTopology initialTopology) {
/**
* Start up Streams with a collection of initial NamedTopologies (may be
empty)
*/
- public void start(final Collection<NamedTopology> initialTopologies) {
+ public synchronized void start(final Collection<NamedTopology>
initialTopologies) {
Review comment:
`super.start()` is already synchronized but we should just go ahead and
synchronize at the first layer
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##########
@@ -145,7 +145,7 @@ public NamedTopologyBuilder newNamedTopologyBuilder(final
String topologyName) {
/**
* @return the NamedTopology for the specific name, or Optional.empty() if
the application has no NamedTopology of that name
*/
- public Optional<NamedTopology> getTopologyByName(final String name) {
+ public synchronized Optional<NamedTopology> getTopologyByName(final String
name) {
Review comment:
Should make sure this is thread safe since it's how we check to make
sure a name isn't already used when trying to add a new topology
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
