showuon commented on a change in pull request #11853:
URL: https://github.com/apache/kafka/pull/11853#discussion_r820193989
##########
File path: core/src/test/scala/unit/kafka/log/LogValidatorTest.scala
##########
@@ -1397,9 +1397,8 @@ class LogValidatorTest {
RecordBatch.MAGIC_VALUE_V0, CompressionType.GZIP, CompressionType.GZIP)
)
// if there is a mix of both regular InvalidRecordException and
InvalidTimestampException,
- // InvalidTimestampException is no longer takes precedence. The type of
invalidException
- // is unified as InvalidRecordException
- assertTrue(e.invalidException.isInstanceOf[InvalidRecordException])
+ // InvalidTimestampException takes precedence
+ assertTrue(e.invalidException.isInstanceOf[InvalidTimestampException])
Review comment:
Since v2.4, (PR: https://github.com/apache/kafka/pull/7612), we
intentionally let `InvalidTimestampException` take precedence. I think we
should keep the same behavior as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
