jolshan commented on a change in pull request #11843:
URL: https://github.com/apache/kafka/pull/11843#discussion_r820912375



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##########
@@ -454,7 +454,7 @@ String 
verifyFullFetchResponsePartitions(Set<TopicPartition> topicPartitions, Se
      * @param topicPartitions  The topicPartitions from the FetchResponse.
      * @param ids              The topic IDs from the FetchResponse.
      * @param version          The version of the FetchResponse.
-     * @return                 True if the incremental fetch response 
partitions are valid.
+     * @return                 null if the incremental fetch response 
partitions are valid; human-readable problem description otherwise.

Review comment:
       These should be non-empty checks. Thanks for catching.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to