showuon edited a comment on pull request #11855: URL: https://github.com/apache/kafka/pull/11855#issuecomment-1062600064
@peterwanner , since this `removing existing public option` needs KIP discussion/voting, and the v3.2.0 already KIP freezed, I think we should revert the change we did in https://github.com/apache/kafka/pull/11517. That means, we don't need the change in `docs/upgrade.html` now. Sorry for not reminding you during the previous PR! So, in short, I need your help to submit a PR (or use this PR) to: 1. revert the change in https://github.com/apache/kafka/pull/11517 to bring the `batchSizeOpt` argument back 2. I found we accidentally remove the line [here](https://github.com/apache/kafka/pull/11517/files#diff-3b7393aaaffd466b3bfc53c8d95109a206442160b878bbdaa0b0332257afaebaL113-L114), where user can set the `max-partition-memory-bytes` to change the `batch.size` in producer. Anyway, please bring it back. 3. Fix the bug in `batchSizeOpt`, by feeding in to the producer `batch.size` config if `batch-size` option is set. So that user can set the `batch.size` via `batch-size` option or `max-partition-memory-bytes` option. 4. In `batch.size` option description, please note that this value in this value will be replaced if `max-partition-memory-bytes` is also set. 5. The result: user can still work well using `batch.size` option (if set), and now, the option will take effect in the producer. And most importantly, it won't break any existing script. 6. For the default value in `batch-size`, we can ignore that. After all, we will (and should) deprecate it soon. Does that make sense? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
