showuon commented on a change in pull request #11864:
URL: https://github.com/apache/kafka/pull/11864#discussion_r822634915
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -1000,8 +1000,11 @@ void invokeCompletedOffsetCommitCallbacks() {
public RequestFuture<Void> commitOffsetsAsync(final Map<TopicPartition,
OffsetAndMetadata> offsets, final OffsetCommitCallback callback) {
invokeCompletedOffsetCommitCallbacks();
- RequestFuture<Void> future = null;
- if (!coordinatorUnknown()) {
+ RequestFuture<Void> future = null;
+ if (offsets.isEmpty()) {
+ // No need to check coordinator if offsets is empty since commit
of empty offsets is completed locally.
+ future = doCommitOffsetsAsync(offsets, callback);
+ } else if (!coordinatorUnknown()) {
future = doCommitOffsetsAsync(offsets, callback);
Review comment:
I'm wonder if other dev would think this is a mistake when seeing this.
Or at least we should leave a comment to mention this is on purpose. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
