jsancio commented on a change in pull request #11733:
URL: https://github.com/apache/kafka/pull/11733#discussion_r825493909
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -147,56 +147,65 @@ sealed trait IsrState {
def maximalIsr: Set[Int]
/**
- * Indicates if we have an AlterIsr request inflight.
+ * The leader recovery state. See the description for LeaderRecoveryState
for details on the different values.
+ */
+ def leaderRecoveryState: LeaderRecoveryState
+
+ /**
+ * Indicates if we have an AlterPartition request inflight.
*/
def isInflight: Boolean
}
-sealed trait PendingIsrChange extends IsrState {
+sealed trait PendingPartitionChange extends PartitionState {
def sentLeaderAndIsr: LeaderAndIsr
+
+ override val leaderRecoveryState: LeaderRecoveryState =
LeaderRecoveryState.RECOVERED
Review comment:
I added `leaderRecoveryState` to the `toString` implementation.
Regarding your other comment, I'll address it in the next PR when I
implement https://issues.apache.org/jira/browse/KAFKA-13696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
