ableegoldman commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r827562746
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##########
@@ -81,14 +81,19 @@ public StreamsBuilder() {
internalStreamsBuilder = new
InternalStreamsBuilder(internalTopologyBuilder);
}
- protected StreamsBuilder(final TopologyConfig topologyConfigs) {
+ /**
+ * Create a {@code StreamsBuilder} instance.
+ *
+ * @param topologyConfigs the streams configs that apply at the
topology level. Please refer to {@link TopologyConfig} for more detail
+ */
+ public StreamsBuilder(final TopologyConfig topologyConfigs) {
topology = getNewTopology(topologyConfigs);
internalTopologyBuilder = topology.internalTopologyBuilder;
internalStreamsBuilder = new
InternalStreamsBuilder(internalTopologyBuilder);
}
protected Topology getNewTopology(final TopologyConfig topologyConfigs) {
Review comment:
@mjsax it's used by the named topology feature -- there is a
`NamedTopologyBuilder` class that extends `StreamsBuilder` and overrides this
method to return a `NamedTopology`.
I know it's a bit awkward, I'll be able to clean it up once I've done the
KIP for this feature (which is, finally, in progress)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
