vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-1068715931
> > If there is, cache, then it hits the underneath caching layer again. I felt this could have been inverted, no? > > Not sure if I can follow. What you exactly mean? > > > And also, if we don't fix caching in this PR, then the results returned with and w/o caching would be different which might be confusing. > > I agree that we should fix it, but we can still can do it in a follow up PR (it's easier to keep a single PR focused on one thing). As long as we ensure that both PRs go into the same release, we avoid this confusing situation for the user. Oops sorry what I meant was the caching store implementation first hits the underneath store and if there's no cache in the context, we return that. If there's a cache found in the context, the computation is done again on the cached data. What I was trying to say was, could this be inverted in the sense first hit the cache if it's defined in the context and return from there otherwise hit the inner store. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
