mimaison commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r828080748



##########
File path: 
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##########
@@ -204,8 +210,6 @@ private void writeTimesAndFlush(OutputStream os, int times, 
byte[] line) throws
 
     @Test
     public void testMissingFile() throws InterruptedException {

Review comment:
       Can we use this opportunity to improve the name of this test? 
`testMissingFile` sounds like we're testing an error case while this is testing 
using stdin instead of file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to