dongjinleekr commented on a change in pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#discussion_r829774103
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -715,19 +713,13 @@ public void shouldLogAndMeterWhenSkippingNullKey() {
.aggregate(MockInitializer.STRING_INIT,
MockAggregator.toStringInstance("+"), Materialized.<String, String,
WindowStore<Bytes,
byte[]>>as("topic1-Canonicalized").withValueSerde(Serdes.String()));
props.setProperty(StreamsConfig.BUILT_IN_METRICS_VERSION_CONFIG,
builtInMetricsVersion);
-
- try (final LogCaptureAppender appender =
LogCaptureAppender.createAndRegister(KStreamSlidingWindowAggregate.class);
+ try (final LogCaptureContext logCaptureContext =
LogCaptureContext.create();
final TopologyTestDriver driver = new
TopologyTestDriver(builder.build(), props)) {
+ logCaptureContext.setLatch(1);
Review comment:
Oh, `await` is just a debris of old approach; it is not called anymore.
So removed, and the documentation on `setLatch` was added instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
